-
Notifications
You must be signed in to change notification settings - Fork 58
[1.21.10] Overhaul owo ItemGroup #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dragon-Seeker
wants to merge
16
commits into
wisp-forest:1.21.9
Choose a base branch
from
Dragon-Seeker:1.21.6-ItemGroupRework
base: 1.21.9
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[1.21.10] Overhaul owo ItemGroup #430
Dragon-Seeker
wants to merge
16
commits into
wisp-forest:1.21.9
from
Dragon-Seeker:1.21.6-ItemGroupRework
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ension of a ItemGroup - Adjust Icons to be more date driven for use in data driven manipulation of item groups - Separate state from item group to allow for proper state on client vs server - Adjust data format for item groups to allow for more features and use endec - Inject owo extensions on server and client - Use item groups registry key rather than item group it self for Item settings
…issing config field
…esides tabs and enable support for condensed entries - Rework DispatchedEndec to use a builder for all the configurable values - Adjust Icon to allow for typeless data decoding
- Allow for the ability to override various rendering aspects of a ItemGroup - Refactor various objects to better packages within itemgroup API - Add Scrollable text draw call similar to minecrafts own - Clip and scroll title of owoitemgroup if name is too big - Allow altering the texture drawn for Page Buttons located to the right added by Fabric API
- Add proper support for REI - Resolve issue with DispatchedEndec not adding directly to the map for the Empty Entry - Adjust Tooltip rendering - Add more configuration options for how condensed entries should function
- Adjust options to show tooltip info to a tristate value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to update owo's built-in
ItemGroupto be instead an extension on top of VanillasItemGroupto be more compatible with other mods and have better handling for Client/Server code.Features:
OwoItemGroupBuilderto either create/modify an ItemGroup, meaning anyItemGroupcan be easily modified in code to be an OwoItemGroupIcons are now data objects with requiredIconRenderto be registered inIconRendererRegistryOwoItemGroupStatehandles all states for active tabs and accessing the given entries for a givenOwoItemGroupCondensedEntrybased on Bedrock's feature, where a given collection of stacks is toggable to either hide or show with a cycling icon